The p2 repository ships a relatively old version of Jetty, i.e., 10.0.13, rather than the most recent 10.0.15 version #1234
Comments
|
@merks Currently I see the same jetty versions. |
|
They must be coming transitively from dependencies in these repositories with older versions of Jetty https://download.eclipse.org/releases/latest I guess because you have a product you pull in a huge number of dependencies into your product's repo and this is the only repo you have which gets contributed to SimRel with older releases of the Platform, WTP and perhaps more... |
|
For sure it comes from https://download.eclipse.org/eclipse/updates/latest as only this repo contains v.10.0.13 |
|
This does too:
So I guess this issue will correct itself after the release June 14th. Given WWD produces releases of products before that time, the only other alternative is to produce releases from other things that are not yet released, which also is not a good alternative. That reminds me that I opened this related issue: Ideally there would be a repository for general updates to WWD as installed in any product rather than only a product update site, but that requires significantly more releng work... |
|
https://download.eclipse.org/releases/2023-06/202306021000/plugins/ has jetty v.10.0.15, so probably it's not yet set as the Anyway, after the release of June 14th, should we re-rebuild/release/contribute to SimRel any products in order to include the latest changes from 2023-06? |
|
Exactly, that will happen precisely on June 14th 9:30 EST. Mostly this problem came to my attention because of this: https://git.eclipse.org/r/c/simrel/org.eclipse.simrel.build/+/202328 So WTP was contributing an old version of WWD and even when that fixed, WTP was still also dragging in some old versions of Jetty that were only available for WWD's repository, which made me wonder why such old versions are there for WWD because if they weren't I'd never have noticed there was an issue with WTP's contribution. But it's clear now that this comes from WWD building a product and using the product repository as the contribution to SimRel. That is not wrong, but it is a source of potential problems and confusion because one never knows if some other thing contributing to SimRel is dragging in a dependencies that come from some older thing only in WWD... It would be much better to have a repository with only WWD's features... |
|
@vrubezhny It's worth trying what is described here https://www.eclipse.org/lists/cross-project-issues-dev/msg19679.html . Instead of bundling refer to the repos and skip things that are in refered repos. |
|
That's a interesting idea... One potential concern with that approach (though I'm just hypothesizing) is that some of these feature includes in the product: result in very specific versions requirements in the product IU: so if the "latest" points at something else that doesn't have these exactly versions, the product's requirement won't be satisfied. So either one has to be more careful using "moving target" repositories or one must be more careful with feature inclusion, even in the product. One might move some features out of a product to a separate feature that imports other features whose versions are likely to change over time... |
|
@akurtakov Adding |
|
This only filters based on the referenced repositories: I believe those are the ones added on the category.xml's Repository Properties page's Additional Repositories section. |
|
Yes, you should add https://download.eclipse.org/eclipse/updates/latest as additional repository . |
|
Adding The full list of plugins not to be added to repository ("../old-repository" - a previous build (master), "./repository" - a build with added "filterProvided" option): |
|
I think this is pretty satisfying result, esp if the produced tarballs are working just fine too. @mickaelistria wdyt? |
|
Keep in mind my comments about the moving target repositories. As soon as there is a release, the product's IU will have requirements that are not satisfied by the references repositories. One might avoid that by using |
|
Yes, it's good to avoid duplicated artifacts if we can reference the upstream platform repo. Note that adding jetty and many others to the repo never was the final intention, this was a side-effect of building a product in the repo. If this |
|
Did you add https://download.eclipse.org/justj/jres/latest in the referenced repos? If so, I expect those will be removed too. Even better, then the user will be able to more easily update to newer Java 17 releases as they become available with potential security updates in those new versions... |
|
@merks After adding https://download.eclipse.org/justj/jres/latest repo to the referenced repo the following plugins were excluded: |
|
The resulting zipped repository size is reduced from 986.4 MB to 268.6 MB. The generated product archives are not changed in their size not contents. |
|
BTW, the resulting product archives stay unchanged and still include jetty "old" 10.0.13 plugins. Hopefully, after the PR #1238 is released,,WWD will not be the reason anymore and problem should go away after the release of June 14th. |
|
You're awesome. 🚀 |
I just wanted to note for completeness: The option only affects how update-sites (p2 repositories) are packed, a product will always contain everything required regardless of the settings, so whatever happens after that should be the part of P2 Updater that will ask the user to install the latest version anyways, so I think even if the product declares a specific (older) version and the site uses a reference to a repository that contains a later version it will still pick up the later one (even though I have not tested it). |
@merks With your precise advice and guidance - that's easy 👍 |
|
@laeubi Great feature, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looking at the repository currently contributed to SimRel
https://download.eclipse.org/wildwebdeveloper/releases/1.1.1/
I see these versions of Jetty:
Version 10.3.15 is available.
It's not clear where these come from because I don't see Jetty in the target platform.
The text was updated successfully, but these errors were encountered: