Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for issue #2426 #2433

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

qtran
Copy link

@qtran qtran commented May 23, 2023

This PR only inlude tests. The test checks that the program args -configuration which was added to the .product file will exist in the resulting .ini file

@qtran qtran changed the title PR for #2426 Add integration test for issue #2426 May 24, 2023
<product uid="ppa.product" id="product" application="application" version="1.0.0.qualifier" useFeatures="false" includeLaunchers="false">

<launcherArgs>
<programArgs>-blah1 -blah2 -configuration @user.dir/configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried writing each arg in one line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, still fails. If you want I could add another product with multiline args

@@ -0,0 +1,49 @@
/*******************************************************************************
* Copyright (c) 2011 Sonatype Inc. and others.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headers seems wrong here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the correct header? I believe I copied it from one of the files from the test package

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you created the file as a whole, you should use the current year and your name here, if you extend a existing file at laest update the year (e.g. 2011, 2023) and add you to the contributor list.

@laeubi
Copy link
Member

laeubi commented Jun 21, 2023

ECA now succeed! So if you squash / rebase this should succeed and be ready to merged.

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Test Results

  606 files    606 suites   4h 7m 47s ⏱️
  431 tests   422 ✅  7 💤 2 ❌
1 293 runs  1 267 ✅ 22 💤 4 ❌

For more details on these failures, see this check.

Results for commit 71a7e33.

♻️ This comment has been updated with latest results.

@qtran
Copy link
Author

qtran commented Jul 23, 2023

I hope i'm doing this right, i've never done that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants