-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for issue #2426 #2433
base: main
Are you sure you want to change the base?
Conversation
<product uid="ppa.product" id="product" application="application" version="1.0.0.qualifier" useFeatures="false" includeLaunchers="false"> | ||
|
||
<launcherArgs> | ||
<programArgs>-blah1 -blah2 -configuration @user.dir/configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried writing each arg in one line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, still fails. If you want I could add another product with multiline args
@@ -0,0 +1,49 @@ | |||
/******************************************************************************* | |||
* Copyright (c) 2011 Sonatype Inc. and others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
headers seems wrong here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the correct header? I believe I copied it from one of the files from the test package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you created the file as a whole, you should use the current year and your name here, if you extend a existing file at laest update the year (e.g. 2011, 2023
) and add you to the contributor list.
ECA now succeed! So if you squash / rebase this should succeed and be ready to merged. |
Test Results 606 files 606 suites 4h 7m 47s ⏱️ For more details on these failures, see this check. Results for commit 71a7e33. ♻️ This comment has been updated with latest results. |
I hope i'm doing this right, i've never done that |
This PR only inlude tests. The test checks that the program args
-configuration
which was added to the .product file will exist in the resulting .ini file