Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(policies): Updated the always-pass policy #1719

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

gerbigf
Copy link
Contributor

@gerbigf gerbigf commented Dec 17, 2024

WHAT

Using "Policy" instead of "Set"will result in an error when trying to create a policy. Replacing the Policy with Set fixes the issue. Also the policy is now aligned with the other examples in the repo.

WHY

The current version was incorrect.

Copy link
Contributor

@rafaelmag110 rafaelmag110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the deps file and we are good to go.

Copy link
Contributor

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Dec 27, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This pull request was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Jan 3, 2025
@lgblaumeiser lgblaumeiser removed the stale label Jan 6, 2025
@lgblaumeiser lgblaumeiser reopened this Jan 6, 2025
@gerbigf
Copy link
Contributor Author

gerbigf commented Jan 8, 2025

@rafaelmag110 tried that and took the latest dependencies from main - still failing...

The let all pass policy was not working. Specifically the policy type "Policy" resulted in an error when creating the policy. Also the policy definition was inconsistent to the other policies on this page.
@gerbigf gerbigf force-pushed the patch-6 branch 3 times, most recently from a59add2 to 307b946 Compare January 8, 2025 15:59
Copy link

sonarqubecloud bot commented Jan 9, 2025

@rafaelmag110 rafaelmag110 merged commit fc2343b into eclipse-tractusx:main Jan 9, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants