Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): adjust schema validation #76

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Oct 15, 2024

Description

schemaType is made optional

Why

To give a better flexibility for the user to execute the schema validation

Issue

Refs: #34

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested review from evegufy and ntruchsess October 15, 2024 12:42
schemaType is made optional

Refs: #34
@Phil91 Phil91 force-pushed the feature/34-validation branch from 867b5f4 to f21001c Compare October 16, 2024 06:32
Copy link

@Phil91 Phil91 added this to the Release 24.12 milestone Oct 16, 2024
@Phil91 Phil91 merged commit 4f9a315 into main Oct 21, 2024
10 checks passed
@Phil91 Phil91 deleted the feature/34-validation branch October 21, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants