chore(dependencies): bump System.Text.Json to 8.0.4 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evegufy
approved these changes
Jul 26, 2024
Phil91
requested changes
Jul 29, 2024
There was a problem hiding this comment.
We should wait until PR eclipse-tractusx/portal-backend#875 is merged and the framework nuget packages are updated. We than can directly update the nuget packages for this project as well.
ntruchsess
force-pushed
the
core/text-json
branch
from
89cdb62 to
3138acd
Compare
Phil91
approved these changes
Jul 29, 2024
Phil91
requested changes
Jul 29, 2024
* reference efcore.design * upgrade framework to 2.4.2
ntruchsess
force-pushed
the
core/text-json
branch
from
3138acd to
65518f8
Compare
Phil91
approved these changes
Jul 29, 2024
|
evegufy
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dependency to Microsoft.EntityFrameworkCore was changed to Microsoft.EntityFrameworkCore.Design 8.0.7
dependency to frameworks was upgraded to 2.4.2
Why
System.Text.Json 8.0.0 has a vulnerability that must be fixed. It is references as an implicit dependency. Referencing Microsoft.EntityFrameworkCore.Design 8.0.7 instead of Microsoft.EntityFrameworkCore implicitly upgrades System.Json.Text to 8.0.4 which solves the security-issue.
Same with frameworks - upgrading to latest 2.4.2 resolves outdated references to System.Text.Json 8.0.0
Issue
eclipse-tractusx/portal#369
Checklist
Please delete options that are not relevant.