fix: remove framework quality (#35)

Refs: #33 Reviewed-By: Evelyn Gurschler <[email protected]>
eclipse-tractusx · Jul 4, 2024 · 2512358 · 2512358
1 parent 8893bbb
commit 2512358
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 17 deletions.
diff --git a/src/database/SsiAuthoritySchemaRegistry.Migrations/Seeder/Data/credential_authorities.json b/src/database/SsiAuthoritySchemaRegistry.Migrations/Seeder/Data/credential_authorities.json
@@ -15,10 +15,6 @@
     "credential_id": "255e01fc-65f6-43cd-8dfa-95e95fa95f63",
     "bpn": "BPNL00000003CRHK"
   },
-  {
-    "credential_id": "255e01fc-65f6-43cd-8dfa-95e95fa95f64",
-    "bpn": "BPNL00000003CRHK"
-  },
   {
     "credential_id": "255e01fc-65f6-43cd-8dfa-95e95fa95f65",
     "bpn": "BPNL00000003CRHK"

diff --git a/src/database/SsiAuthoritySchemaRegistry.Migrations/Seeder/Data/credentials.json b/src/database/SsiAuthoritySchemaRegistry.Migrations/Seeder/Data/credentials.json
@@ -19,11 +19,6 @@
     "type_id": 3,
     "name": "QualityCredential"
   },
-  {
-    "id": "255e01fc-65f6-43cd-8dfa-95e95fa95f64",
-    "type_id": 3,
-    "name": "Framework Quality"
-  },
   {
     "id": "255e01fc-65f6-43cd-8dfa-95e95fa95f65",
     "type_id": 3,

diff --git a/tests/database/SsiAuthoritySchemaRegistry.DbAccess.Tests/CredentialRepositoryTests.cs b/tests/database/SsiAuthoritySchemaRegistry.DbAccess.Tests/CredentialRepositoryTests.cs
@@ -55,12 +55,11 @@ public async Task GetCredentials_WithValidData_ReturnsExpected()
         var result = await sut.GetCredentials(null, null).ToListAsync();
 
         // Assert
-        result.Should().HaveCount(12).And.Satisfy(
+        result.Should().HaveCount(11).And.Satisfy(
             x => x.CredentialName == "BusinessPartnerNumber" && x.Credential == "BusinessPartnerCredential",
             x => x.CredentialName == "Membership" && x.Credential == "MembershipCredential",
             x => x.CredentialName == "Framework" && x.Credential == "TraceabilityCredential",
             x => x.CredentialName == "Framework" && x.Credential == "QualityCredential",
-            x => x.CredentialName == "Framework" && x.Credential == "Framework Quality",
             x => x.CredentialName == "Framework" && x.Credential == "CircularEconomyCredential",
             x => x.CredentialName == "Framework" && x.Credential == "PcfCredential",
             x => x.CredentialName == "Framework" && x.Credential == "DemandCapacityCredential",
@@ -94,10 +93,9 @@ public async Task GetCredentials_WithTypeFilter_ReturnsExpected()
         var result = await sut.GetCredentials(null, CredentialTypeId.Framework).ToListAsync();
 
         // Assert
-        result.Should().HaveCount(9).And.Satisfy(
+        result.Should().HaveCount(8).And.Satisfy(
             x => x.CredentialName == "Framework" && x.Credential == "TraceabilityCredential",
             x => x.CredentialName == "Framework" && x.Credential == "QualityCredential",
-            x => x.CredentialName == "Framework" && x.Credential == "Framework Quality",
             x => x.CredentialName == "Framework" && x.Credential == "CircularEconomyCredential",
             x => x.CredentialName == "Framework" && x.Credential == "PcfCredential",
             x => x.CredentialName == "Framework" && x.Credential == "DemandCapacityCredential",

diff --git a/.../registry/SsiAuthoritySchemaRegistry.Service.Tests/Controllers/RegistryControllerTests.cs b/.../registry/SsiAuthoritySchemaRegistry.Service.Tests/Controllers/RegistryControllerTests.cs
@@ -52,12 +52,11 @@ public async Task GetCredentials_WithoutFilters_ReturnsExpected()
         var data = await _client.GetFromJsonAsync<IEnumerable<CredentialData>>($"{BaseUrl}/credentials", JsonOptions);
 
         // Assert
-        data.Should().NotBeNull().And.HaveCount(12).And.Satisfy(
+        data.Should().NotBeNull().And.HaveCount(11).And.Satisfy(
             x => x.CredentialName == "BusinessPartnerNumber" && x.Credential == "BusinessPartnerCredential",
             x => x.CredentialName == "Membership" && x.Credential == "MembershipCredential",
             x => x.CredentialName == "Framework" && x.Credential == "TraceabilityCredential",
             x => x.CredentialName == "Framework" && x.Credential == "QualityCredential",
-            x => x.CredentialName == "Framework" && x.Credential == "Framework Quality",
             x => x.CredentialName == "Framework" && x.Credential == "CircularEconomyCredential",
             x => x.CredentialName == "Framework" && x.Credential == "PcfCredential",
             x => x.CredentialName == "Framework" && x.Credential == "DemandCapacityCredential",
@@ -86,10 +85,9 @@ public async Task GetCredentials_WithCredentialTypeFilters_ReturnsExpected()
         var data = await _client.GetFromJsonAsync<IEnumerable<CredentialData>>($"{BaseUrl}/credentials?credentialTypeId={CredentialTypeId.Framework}", JsonOptions);
 
         // Assert
-        data.Should().HaveCount(9).And.Satisfy(
+        data.Should().HaveCount(8).And.Satisfy(
             x => x.CredentialName == "Framework" && x.Credential == "TraceabilityCredential",
             x => x.CredentialName == "Framework" && x.Credential == "QualityCredential",
-            x => x.CredentialName == "Framework" && x.Credential == "Framework Quality",
             x => x.CredentialName == "Framework" && x.Credential == "CircularEconomyCredential",
             x => x.CredentialName == "Framework" && x.Credential == "PcfCredential",
             x => x.CredentialName == "Framework" && x.Credential == "DemandCapacityCredential",