Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add workflow to create svg puml #63

Merged
merged 6 commits into from
Oct 30, 2023
Merged

CI: Add workflow to create svg puml #63

merged 6 commits into from
Oct 30, 2023

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Oct 30, 2023 •
edited
Loading

Description

Adds the following workflow: https://github.com/eclipse-tractusx/sig-infra#generate-static-plantuml-files

Updates the container jobs to not run on forks.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

mhellmeier
mhellmeier requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments. Please also check the boxes in the PR description (pre-review checks).

.github/workflows/render-puml-to-svg.yml Outdated Show resolved Hide resolved
.github/workflows/render-puml-to-svg.yml Outdated Show resolved Hide resolved
@tom-rm-meyer-ISST
Copy link
Contributor Author

See the comments. Please also check the boxes in the PR description (pre-review checks).

you're right, forgot to check them.

mhellmeier
mhellmeier approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhellmeier mhellmeier merged commit 60b508f into eclipse-tractusx:main Oct 30, 2023
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the ci/static-puml branch October 30, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhellmeier mhellmeier mhellmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-rm-meyer-ISST @mhellmeier