Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/Submodel registration and production SAMM #346

Merged
merged 10 commits into from
Apr 26, 2024
Merged

Feat/Submodel registration and production SAMM #346

merged 10 commits into from
Apr 26, 2024

Conversation

ReneSchroederLJ
Copy link
Member

@ReneSchroederLJ ReneSchroederLJ commented Apr 25, 2024 •
edited
Loading

Description

  • refactored the registration of submodels to be reusable
  • refactored the contract definitions to be reusable
  • implemented the registration of submodels for production, demand and delivery
  • implemented SAMM models for Planned Production Output

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ReneSchroederLJ ReneSchroederLJ marked this pull request as ready for review April 25, 2024 07:44
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring! A few changes needed, some questions just for curiosity.

...d/src/main/java/org/eclipse/tractusx/puris/backend/common/edc/domain/model/SubmodelType.java Outdated Show resolved Hide resolved
...d/src/main/java/org/eclipse/tractusx/puris/backend/common/edc/domain/model/SubmodelType.java Outdated Show resolved Hide resolved
...main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/service/EdcAdapterService.java Outdated Show resolved Hide resolved
...main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/service/EdcAdapterService.java Outdated Show resolved Hide resolved
...ain/java/org/eclipse/tractusx/puris/backend/common/edc/logic/util/EdcRequestBodyBuilder.java Outdated Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 5a3a496 into eclipse-tractusx:main Apr 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReneSchroederLJ @tom-rm-meyer-ISST