-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create security-assessment.md #235
Conversation
Initiation
Added scope of the review
Finalisation of assessment. DF to be added by Szymon later after pull request.
@szymonkowalczykzf please also have a look as from your point of view. |
@tom-rm-meyer-ISST please check if the file location suits you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Location is fine. Thanks for providing. Had a few questions and adoptions. Sorry for not raising them earlier.
| ------------------------- | ---------------------------------------------------------------------------------------------- | | ||
| Contact for product | [@tom-rm-meyer-ISST](https://github.com/tom-rm-meyer-ISST) | | ||
| Security responsible | [@SSIRKC](https://github.com/SSIRKC) <br> [@szymonkowalczykzf](https://github.com/szymonkowalczykzf) | | ||
| Version number of product | 23.12 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security Assessment has been conducted for Release 24.03. Thus it is correct, isn't it? Just want to confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Tom, you need to schedule a new assessment for 24.03. This is only the migration to GitHub :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, We didn't participate in R23.12 and therefore just wanted to be fast enough for R24.03. Also when talking about prioritization things have been postponed for R24.05.
But I can open a ticket so that we're in line again :)
Updated according to the requests.
Raised issue for re-assesment for R24.03. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot! As commented I raised an assesment request for R24.03.
@SSIRKC could you please synchronize your fork and merge main? Seems like I can't automerge :( |
Sinced my fork, but I cant automerge. Does it work now for you? :) |
@tom-rm-meyer-ISST You will have to first merge before I can provide changes with the regards to the diagram we have spoke about today. As soon as file will be merged I will pull request to include the diagram. |
@szymonkowalczykzf sorry, I missed to merge it after past merge of @SSIRKC. @SSIRKC could you please sync and merge again? :/ |
Hi @tom-rm-meyer-ISST , I sinced again but I cant merge I think. Do I have the rights for it? I am not comitter |
It's still out of date in Github. Could you please check if you synchronized your branch beforehand merging main? |
Merged again, not sure what is going wrong :D
|
Whatever you did differently or again - it worked :) |
Kristian, Tom, thanks for your work on that. Please let me know in case of any issues. |
Hello PURIS team,
as already announced we are moving the assessments to GitHub.
Please note that we have not published open severe findings if there any.
This assessment file is a requirement for all quality gates and has to be provided as proof.
Please also note that this current assessment file only documents the situtation of release 23.12.
An update is required for the Q1 release 2024.
@szymonkowalczykzf please add the dataflow diagram in a separate pull request.