Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create security-assessment.md #235

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

SSIRKC
Copy link
Contributor

@SSIRKC SSIRKC commented Feb 2, 2024

Hello PURIS team,

as already announced we are moving the assessments to GitHub.

Please note that we have not published open severe findings if there any.

This assessment file is a requirement for all quality gates and has to be provided as proof.

Please also note that this current assessment file only documents the situtation of release 23.12.
An update is required for the Q1 release 2024.

@szymonkowalczykzf please add the dataflow diagram in a separate pull request.

Added scope of the review
Finalisation of assessment. DF to be added by Szymon later after pull request.
@SSIRKC SSIRKC marked this pull request as ready for review February 2, 2024 13:13
@SSIRKC
Copy link
Contributor Author

SSIRKC commented Feb 2, 2024

@szymonkowalczykzf please also have a look as from your point of view.

@SSIRKC
Copy link
Contributor Author

SSIRKC commented Feb 2, 2024

@tom-rm-meyer-ISST please check if the file location suits you.

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Location is fine. Thanks for providing. Had a few questions and adoptions. Sorry for not raising them earlier.

| ------------------------- | ---------------------------------------------------------------------------------------------- |
| Contact for product | [@tom-rm-meyer-ISST](https://github.com/tom-rm-meyer-ISST) |
| Security responsible | [@SSIRKC](https://github.com/SSIRKC) <br> [@szymonkowalczykzf](https://github.com/szymonkowalczykzf) |
| Version number of product | 23.12 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Assessment has been conducted for Release 24.03. Thus it is correct, isn't it? Just want to confirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tom, you need to schedule a new assessment for 24.03. This is only the migration to GitHub :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, We didn't participate in R23.12 and therefore just wanted to be fast enough for R24.03. Also when talking about prioritization things have been postponed for R24.05.

But I can open a ticket so that we're in line again :)

docs/security-assessment.md Outdated Show resolved Hide resolved
docs/security-assessment.md Outdated Show resolved Hide resolved
docs/security-assessment.md Outdated Show resolved Hide resolved
docs/security-assessment.md Outdated Show resolved Hide resolved
docs/security-assessment.md Outdated Show resolved Hide resolved
Updated according to the requests.
@tom-rm-meyer-ISST
Copy link
Contributor

Raised issue for re-assesment for R24.03.

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot! As commented I raised an assesment request for R24.03.

@tom-rm-meyer-ISST
Copy link
Contributor

@SSIRKC could you please synchronize your fork and merge main? Seems like I can't automerge :(

@SSIRKC
Copy link
Contributor Author

SSIRKC commented Feb 5, 2024

@SSIRKC could you please synchronize your fork and merge main? Seems like I can't automerge :(

Sinced my fork, but I cant automerge. Does it work now for you? :)

@szymonkowalczykzf
Copy link
Contributor

@tom-rm-meyer-ISST You will have to first merge before I can provide changes with the regards to the diagram we have spoke about today. As soon as file will be merged I will pull request to include the diagram.

@tom-rm-meyer-ISST
Copy link
Contributor

@szymonkowalczykzf sorry, I missed to merge it after past merge of @SSIRKC.

@SSIRKC could you please sync and merge again? :/

@SSIRKC
Copy link
Contributor Author

SSIRKC commented Feb 16, 2024

@szymonkowalczykzf sorry, I missed to merge it after past merge of @SSIRKC.

@SSIRKC could you please sync and merge again? :/

Hi @tom-rm-meyer-ISST , I sinced again but I cant merge I think. Do I have the rights for it? I am not comitter

@tom-rm-meyer-ISST
Copy link
Contributor

@szymonkowalczykzf sorry, I missed to merge it after past merge of @SSIRKC.
@SSIRKC could you please sync and merge again? :/

Hi @tom-rm-meyer-ISST , I sinced again but I cant merge I think. Do I have the rights for it? I am not comitter

It's still out of date in Github. Could you please check if you synchronized your branch beforehand merging main?

@SSIRKC
Copy link
Contributor Author

SSIRKC commented Feb 16, 2024

Merged again, not sure what is going wrong :D

@szymonkowalczykzf sorry, I missed to merge it after past merge of @SSIRKC.
@SSIRKC could you please sync and merge again? :/

Hi @tom-rm-meyer-ISST , I sinced again but I cant merge I think. Do I have the rights for it? I am not comitter

It's still out of date in Github. Could you please check if you synchronized your branch beforehand merging main?

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 753580c into eclipse-tractusx:main Feb 16, 2024
11 checks passed
@tom-rm-meyer-ISST
Copy link
Contributor

Merged again, not sure what is going wrong :D

@szymonkowalczykzf sorry, I missed to merge it after past merge of @SSIRKC.
@SSIRKC could you please sync and merge again? :/

Hi @tom-rm-meyer-ISST , I sinced again but I cant merge I think. Do I have the rights for it? I am not comitter

It's still out of date in Github. Could you please check if you synchronized your branch beforehand merging main?

Whatever you did differently or again - it worked :)

@szymonkowalczykzf
Copy link
Contributor

Kristian, Tom, thanks for your work on that.
I have created another pull request with changes to the assessment md file.

Please let me know in case of any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants