-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: added helm-test chart workflow (TRG 5.07) #145
ci: added helm-test chart workflow (TRG 5.07) #145
Conversation
Hey @almadigabor, could you do a review and tell me why it fails due to kind version 1.27.3? |
@tomaszbarwicki, linting progresses but the dockerfile can't be read in this run.
Do you got an idea why? |
Hey @tom-rm-meyer-ISST! The current issue happens because the action does not point to the Dockerfile's path using the |
Hey @almadigabor, needed some free space to have a look into it again. It now works. Thanks for your support. Could you please do the final review and accept it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow looks good now, although the actual chart-testing (install) step did not run as no chart changes were detected. Anyways I'll approve this PR.
Hey @tomaszbarwicki! Looks like you requested some changes that are outdated now. Can you re-review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds the helm test workflow according to TRG 5.07. To clarify, if helm upgrade between charts is applicable to us.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: