Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: added helm-test chart workflow (TRG 5.07) #145

Merged
merged 14 commits into from
Feb 16, 2024

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Dec 20, 2023

Description

Adds the helm test workflow according to TRG 5.07. To clarify, if helm upgrade between charts is applicable to us.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@tom-rm-meyer-ISST
Copy link
Contributor Author

Hey @almadigabor, could you do a review and tell me why it fails due to kind version 1.27.3?

.github/workflows/helm-test.yml Outdated Show resolved Hide resolved
.github/workflows/helm-test.yml Outdated Show resolved Hide resolved
@tom-rm-meyer-ISST
Copy link
Contributor Author

@tomaszbarwicki, linting progresses but the dockerfile can't be read in this run.

ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount2079917770/Dockerfile: no such file or directory
Error: buildx failed with: ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount2079917770/Dockerfile: no such file or directory

Do you got an idea why?

@tom-rm-meyer-ISST tom-rm-meyer-ISST removed the request for review from almadigabor January 4, 2024 12:04
@almadigabor
Copy link

almadigabor commented Jan 4, 2024

@tomaszbarwicki, linting progresses but the dockerfile can't be read in this run.

ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount2079917770/Dockerfile: no such file or directory
Error: buildx failed with: ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount2079917770/Dockerfile: no such file or directory

Do you got an idea why?

Hey @tom-rm-meyer-ISST! The current issue happens because the action does not point to the Dockerfile's path using the context variable. You have your Dockerfiles in the frontend and backend directory. Based on your setup you should build both by duplicating the build step and create a frontend and backend image as well. Then in the end make sure to set the proper registry, app name and tag in the chart install step. You can find a good example here building frontend and backend images and then using them with the chart at the end.

@tom-rm-meyer-ISST
Copy link
Contributor Author

Hey @almadigabor, needed some free space to have a look into it again. It now works. Thanks for your support. Could you please do the final review and accept it?

Copy link

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow looks good now, although the actual chart-testing (install) step did not run as no chart changes were detected. Anyways I'll approve this PR.

@almadigabor
Copy link

Hey @tomaszbarwicki! Looks like you requested some changes that are outdated now. Can you re-review this PR?

Copy link
Contributor

@tomaszbarwicki tomaszbarwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit da3c3b6 into eclipse-tractusx:main Feb 16, 2024
13 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the ci/helm-test branch February 16, 2024 06:53
@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Feb 16, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants