fix(UI): card component spaces #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usmanfee
requested review from
oyo and
MaximilianHauer
and removed request for
oyo and
MaximilianHauer
Usmanfee
changed the title
MaximilianHauer
requested review from
oyo and
manojava-gk
and removed request for
oyo
ybidois
reviewed
Oct 2, 2024
|
@Usmanfee pr is still in draft |
|
oyo
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Card component wasn't handling longer text description gracefully and some Label and typography elements spaces wasn't consistent to look appealing. I implemented some new css properties to make longer text transition in truncate and introduced margin around text elements.
Why
The longer text cause broken UI and user can't read the rest of the information which was coming beneath the card component.
After fix:
Issue
#335
Checklist