Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing RETRIGGER_CREATE_DIM_WALLET type and EndUrl for registration process #998

Merged

Conversation

typecastcloud
Copy link
Contributor

@typecastcloud typecastcloud commented Aug 9, 2024

Description

Add missing RETRIGGER_CREATE_DIM_WALLET type and EndUrl for registration process

Why

404 not found if trying to retrigger dim wallet creation.

Issue

Refs: #997

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes

…stration process

Causing 404 not found because step will resolve into undefined instead.

Refs: eclipse-tractusx#997
Copy link

sonarqubecloud bot commented Aug 9, 2024

@typecastcloud typecastcloud self-assigned this Aug 9, 2024
@evegufy evegufy added this to the Release 24.12 milestone Aug 14, 2024
@evegufy
Copy link
Contributor

evegufy commented Aug 14, 2024

@Phil91 Please check this change in the context of eclipse-tractusx/sig-release#802
might not be a fix but an enhancement.

cc: @MaximilianHauer

@typecastcloud
Copy link
Contributor Author

@Phil91 Please check this change in the context of eclipse-tractusx/sig-release#802 might not be a fix but an enhancement.

cc: @MaximilianHauer

Retrigger button is already available. Thats why we thought it is a bug.

@Phil91
Copy link
Member

Phil91 commented Aug 19, 2024

there will be some more retrigger steps in the future, on backend side we already added the missing ones and endpoints for some which were existing. Currently available as a PR: eclipse-tractusx/portal-backend#915

@typecastcloud
Copy link
Contributor Author

there will be some more retrigger steps in the future, on backend side we already added the missing ones and endpoints for some which were existing. Currently available as a PR: eclipse-tractusx/portal-backend#915

I can close this PR if someone from frontend is already taking care of all the missing steps.

@Phil91
Copy link
Member

Phil91 commented Aug 19, 2024

there will be some more retrigger steps in the future, on backend side we already added the missing ones and endpoints for some which were existing. Currently available as a PR: eclipse-tractusx/portal-backend#915

I can close this PR if someone from frontend is already taking care of all the missing steps.

I think we can merge this PR, it's a quick win and one less endpoint / retrigger step we need to implement :)

@oyo could you have a look at it?

@MaximilianHauer MaximilianHauer added the priority PR needs to prioritized at review label Aug 19, 2024
@oyo oyo merged commit bd07960 into eclipse-tractusx:main Aug 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

5 participants