Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(registration): delete idp on application decline #371

Merged
merged 3 commits into from
Dec 15, 2023
Merged

fix(registration): delete idp on application decline #371

merged 3 commits into from
Dec 15, 2023

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Dec 4, 2023

Description

When declining an application the idp of the company is set to disabled

Why

When declining an application a user is still able to login for the idp of the declined company, this shouldn't be possible

Issue

N/A - Jira Issue: TEST-1642

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 force-pushed the bugfix/TEST-1642-decline branch from 9381913 to fe8addb Compare December 4, 2023 14:07
@Phil91 Phil91 marked this pull request as ready for review December 4, 2023 14:14
@Phil91 Phil91 requested a review from ntruchsess December 4, 2023 14:14
@Phil91 Phil91 marked this pull request as draft December 4, 2023 15:46
@Phil91 Phil91 force-pushed the bugfix/TEST-1642-decline branch 3 times, most recently from b113d4f to bd18e8d Compare December 4, 2023 17:19
@Phil91 Phil91 changed the title fix(registration): disable idp on application decline fix(registration): delete idp on application decline Dec 4, 2023
@Phil91 Phil91 marked this pull request as ready for review December 4, 2023 17:26
@Phil91 Phil91 force-pushed the bugfix/TEST-1642-decline branch from bd18e8d to 9954285 Compare December 11, 2023 13:48
@jjeroch jjeroch added the priority PR needs to prioritized at review label Dec 14, 2023
@ntruchsess ntruchsess force-pushed the bugfix/TEST-1642-decline branch 2 times, most recently from 6a35827 to d8ebaeb Compare December 14, 2023 18:16
ntruchsess
ntruchsess previously approved these changes Dec 14, 2023
View reviewed changes
@Phil91 Phil91 force-pushed the bugfix/TEST-1642-decline branch from d8ebaeb to cc3c917 Compare December 15, 2023 13:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess merged commit fb5b9a3 into eclipse-tractusx:dev Dec 15, 2023
5 checks passed
@ntruchsess ntruchsess deleted the bugfix/TEST-1642-decline branch December 15, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

Assignees
No one assigned
Labels
priority PR needs to prioritized at review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @ntruchsess @jjeroch