feat(app&service): enable provider to decline subscription request #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tests/marketplace/Offers.Library.Tests/Service/OfferSubscriptionServiceTests.cs
Fixed
Show fixed
Hide fixed
6 tasks
|
Please resolve conflict and take care of codeql finding |
evegufy
changed the title
Phil91
requested changes
Dec 13, 2024
src/portalbackend/PortalBackend.DBAccess/Repositories/OfferSubscriptionsRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/IOfferSubscriptionsRepository.cs
Outdated
Show resolved
Hide resolved
src/marketplace/Offers.Library/Service/OfferSubscriptionService.cs
Outdated
Show resolved
Hide resolved
...rtalBackend.Migrations/Migrations/20241121163647_1140_Decline-Offer-Subscription.Designer.cs
Outdated
Show resolved
Hide resolved
...ackend/PortalBackend.Migrations/Migrations/20241121163647_1140_Decline-Offer-Subscription.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.Migrations/Migrations/PortalDbContextModelSnapshot.cs
Outdated
Show resolved
Hide resolved
src/marketplace/Offers.Library/Service/OfferSubscriptionService.cs
Outdated
Show resolved
Hide resolved
…line the Subscription request Ref: eclipse-tractusx#1140 - /api/apps/subscription/{subscriptionId}/decline - /api/services/subscription/{subscriptionId}/decline
tfjanjua
force-pushed
the
feat/1140-offer-subscription-decline
branch
from
6bc0414 to
4084a3a
Compare
tests/marketplace/Offers.Library.Tests/Service/OfferSubscriptionServiceTests.cs
Fixed
Show fixed
Hide fixed
Phil91
requested changes
Jan 6, 2025
src/marketplace/Offers.Library/Service/OfferSubscriptionService.cs
Outdated
Show resolved
Hide resolved
src/marketplace/Offers.Library/Service/OfferSubscriptionService.cs
Outdated
Show resolved
Hide resolved
|
|
@evegufy | @Phil91 | @ntruchsess |
|
Dear Team, could you take this item with priority? Thank you! |
@dorkabcox review done, I'll merge it after our release today. |
Phil91
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ability for App or Service Provider to Decline the Subscription request
Why
Currently this functionality not exists and its one of the requests from real users.
Issue
Ref: #1140
Corresponding IAM PR
eclipse-tractusx/portal-iam#233
Checklist