Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore|fix(remoting): Enhance manual build trigger and fix docker glitches due to migrating from maven to github actions #46

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Oct 9, 2023

WHAT

Manual triggering of the build workflow now comes with deployment options for maven and docker.
Docker setup of remoting agent has been debugged.
Also a yamllint check was done on the workflows.

WHY

When migrating from a maven to a github-action-based docker build based on release branches and tags, two glitches at the docker artifacts (not the maven artifacts) have been introduced. This PR solves the glitches as well as the opportunity to fix them in all future releases.

FURTHER NOTES

Closes #44 <-- insert Issue number if one exists

@drcgjung drcgjung marked this pull request as ready for review October 9, 2023 13:21
@drcgjung
Copy link
Contributor Author

drcgjung commented Oct 9, 2023

Hello @carslen this is the "main" companion to the specific 1.9.8/23.09 fix #45

it needs no manual triggering, but serves to persist the above changes.

Copy link
Contributor

@carslen carslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carslen carslen merged commit 57a8bda into eclipse-tractusx:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remoting-Agent (Docker): Release Images lack CallbackHandler functionality/code.
2 participants