fix: check connector urls and headers coming from config. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Improves url and header checking in AgentConfig.
WHY
CodeQL complains about some potential SSF traps.
FURTHER NOTES
Wrt to sanitizing other dynamic SSF sources which CodeQL may not correctly detect, please have a look at:
knowledge-agents/matchmaking/src/main/java/org/eclipse/tractusx/agents/http/GraphController.java
Line 155 in 05827e2
knowledge-agents/matchmaking/src/main/java/org/eclipse/tractusx/agents/http/DelegationServiceImpl.java
Line 215 in 05827e2
knowledge-agents/matchmaking/src/main/java/org/eclipse/tractusx/agents/http/DelegationServiceImpl.java
Line 219 in 05827e2
Closes #128