chore|style: code-style validation through checkstyle and reformat according to tractus-x style guide #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcgjung
changed the title
drcgjung
changed the title
drcgjung
changed the title
agent-plane/agent-plane-protocol/src/main/java/org/eclipse/tractusx/agents/edc/SkillStore.java
Show resolved
Hide resolved
...ne-protocol/src/main/java/org/eclipse/tractusx/agents/edc/service/DataspaceSynchronizer.java
Show resolved
Hide resolved
...ne-protocol/src/main/java/org/eclipse/tractusx/agents/edc/service/DataspaceSynchronizer.java
Show resolved
Hide resolved
Martin0815bla
approved these changes
Oct 19, 2023
|
@carslen with my best regards, here is another checkstyle introduction that has been already checked by @Martin0815bla for possible IP changes |
drcgjung
changed the title
SebastianBezold
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR introduces checkstyle into the build process based on the Tractus-X style guide for Java.
It also performs the whole reformatting necessary on the source files.
Finally it did a DEPENDENCY check using a more up-to-date dash version.
WHY
Developers from other parts of Tractus-X were confused by the current approach (which was mostly checked with spotless and without any specific rules).
FURTHER NOTES
Closes #57 <-- insert Issue number if one exists
Closes #76
May conflict with other PRs of higher priority in which case this needs to be resolved.