-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added vault image to TRG 4.06 #370
feat: added vault image to TRG 4.06 #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @tom-rm-meyer-ISST, thanks for creating PR with the vault image proposal. I suggest we first create a draft version with the change of new image so everyone interested can provide feedback before we publish it. Please follow described process: https://eclipse-tractusx.github.io/docs/release
I reverted the changes to TRG 4.06 and
Please check, if I got the process right. If yes, thenI can write to the mailing list. I guess it still is a fast release case, isn't it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Right, seems to be fast case.
@tomaszbarwicki shall I write the mail with regard to this PR or do we need to merge first so that I can review the draft on https://eclipse-tractusx.github.io/docs/release/trg-0/ ? |
@tom-rm-meyer-ISST please merge first and mail afterwards. |
Hey @SebastianBezold, could you please check and merge so that we can ask the others via the mailing list? |
@tom-rm-meyer-ISST Sebastian is on leave. Please fix the conflict and write to me on teams and i will merge it |
Resolved merge conflict. After merging, I'll write to the mailing list. Last time @AngelikaWittek told us to keep holding as we're waiting for updates regarding the licence issue. |
Unfortunately there is another merge conflict after merging a different PR. Sorry. |
resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've approved the changes and merged the PR. @tom-rm-meyer-ISST you can send the mail you discussed in the previous comments.
Hey @almadigabor, I think this was a bit too quick. In my opinion we will never align on HashiCorp Vault as a base image. We do aline on images, that are used for our published app images. Vault is only used (AFAIK) as supporting infrastructure component. FYI @AngelikaWittek |
Hey @SebastianBezold! Good point, but it's still draft and up to changes so can be corrected if necessary. I only looked at the comments and was already approved and wasn't merged only because of merge conflicts. |
Description
The vault image with an image tag lower 1.14.2 are licensed unter MPL2.0 receives security updates by end of this year. For current use this is OK. See this discussion.
This PR closes sig-infra issue 247.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: