Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added vault image to TRG 4.06 #370

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Sep 1, 2023

Description

The vault image with an image tag lower 1.14.2 are licensed unter MPL2.0 receives security updates by end of this year. For current use this is OK. See this discussion.

This PR closes sig-infra issue 247.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@tomaszbarwicki tomaszbarwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @tom-rm-meyer-ISST, thanks for creating PR with the vault image proposal. I suggest we first create a draft version with the change of new image so everyone interested can provide feedback before we publish it. Please follow described process: https://eclipse-tractusx.github.io/docs/release

@tom-rm-meyer-ISST
Copy link
Contributor Author

I reverted the changes to TRG 4.06 and

  • moved the changed file to folder trg-0
  • added an entry to table trg-0/trg-0.md

Please check, if I got the process right.

If yes, thenI can write to the mailing list. I guess it still is a fast release case, isn't it?

Copy link
Contributor

@tomaszbarwicki tomaszbarwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Right, seems to be fast case.

@tom-rm-meyer-ISST
Copy link
Contributor Author

@tomaszbarwicki shall I write the mail with regard to this PR or do we need to merge first so that I can review the draft on https://eclipse-tractusx.github.io/docs/release/trg-0/ ?

@tomaszbarwicki
Copy link
Contributor

@tom-rm-meyer-ISST please merge first and mail afterwards.

@tom-rm-meyer-ISST
Copy link
Contributor Author

Hey @SebastianBezold, could you please check and merge so that we can ask the others via the mailing list?

@Siegfriedk
Copy link
Contributor

@tom-rm-meyer-ISST Sebastian is on leave. Please fix the conflict and write to me on teams and i will merge it

@tom-rm-meyer-ISST
Copy link
Contributor Author

Resolved merge conflict. After merging, I'll write to the mailing list. Last time @AngelikaWittek told us to keep holding as we're waiting for updates regarding the licence issue.

@carslen
Copy link
Contributor

carslen commented Oct 5, 2023

Unfortunately there is another merge conflict after merging a different PR. Sorry.

@tom-rm-meyer-ISST
Copy link
Contributor Author

Unfortunately there is another merge conflict after merging a different PR. Sorry.

resolved

Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've approved the changes and merged the PR. @tom-rm-meyer-ISST you can send the mail you discussed in the previous comments.

@almadigabor almadigabor merged commit 663f295 into eclipse-tractusx:main Nov 10, 2023
2 checks passed
@SebastianBezold
Copy link
Contributor

Hey @almadigabor, I think this was a bit too quick. In my opinion we will never align on HashiCorp Vault as a base image. We do aline on images, that are used for our published app images. Vault is only used (AFAIK) as supporting infrastructure component.

FYI @AngelikaWittek

@almadigabor
Copy link
Contributor

Hey @SebastianBezold! Good point, but it's still draft and up to changes so can be corrected if necessary. I only looked at the comments and was already approved and wasn't merged only because of merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vault Dockerfile and TRG 4.06
6 participants