-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circularity kit update 24.08 adoption view fixed #1088
Circularity kit update 24.08 adoption view fixed #1088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuisRickert thanks for the PR. Can you please check the DEPENDENCIES file? It seems to be outdated. Since this is a PR with more than 1000 changes, I have to create an IP Ticket on the Eclipse side.
⇾ I will do this and link it to the PR.
Furthermore, thanks for adding the licence files for each picture … right now, there are many companies named. Is it just a copy & paste error? Or did they all contribute here? Or was this done by you?
@jSchuetz88 FYI
I'll check the dependency file. Still i'm confused that this check is failing since i did a rebase for this fixed PR so it is up to date (Yesterday evening) and we didn't do any changes to that file. wrt. the license files, i just used the exsisting one, since i was. just the person who was tasked to create the PR. |
Hey @stephanbcbauer i did some investigation. The "DEPENDENCIES" file is generated by the "3rd Party dependency"-Job based on the package-lock.json file. My reasoning:
are the any guidance on this or have i missed something ? |
…8-Adoption-View-Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Is there an associated IP check ticket? If not, @stephanbcbauer could you please create one?
Beside the IP-check my only remark refers to the changelog (see comment below).
### Removed | ||
|
||
- ./. | ||
|
||
## [1.3.0] - 17.09.2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused here about the order? Why is version 1.2.0 newer than version 1.3.0?
And already approved. |
PR Release relevant ⇾ minor issues will be resolved within a bugfix branch
overall PR checked by @ther3sa , @jSchuetz88 , @stephanbcbauer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see last comment
Description
Added
Changed
Issue 703
REPLACES PR 925
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: