Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: select verification method from did document as per kid of JWT #99

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: select verification method from did document as per kid of JWT #99

wants to merge 3 commits into from

Conversation

nitin-vavdiya
Copy link
Contributor

@nitin-vavdiya nitin-vavdiya commented May 8, 2024 •
edited
Loading

Description

Changes done:

  1. Select the verification method with a matching kid header of JWT while verification
  2. Throws IllegalArgumentException if no match is found
  3. minor code refactoring for SignedJwtVerifier, Ed25519VerificationMethod and JWKVerificationMethod

Fix: #98

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nitin-vavdiya nitin-vavdiya changed the title fix: select verification method from did document as per kid header v… fix: select verification method from did document as per kid of JWT May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borisrizov-zf borisrizov-zf Awaiting requested review from borisrizov-zf

@DominikPinsel DominikPinsel Awaiting requested review from DominikPinsel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify JWT according to kid header instead of checking with all verification method
1 participant
@nitin-vavdiya