This repository has been archived by the owner on Jan 20, 2025. It is now read-only.
Add credential service to DID document #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisrizov-zf
approved these changes
Mar 5, 2024
| Objects.requireNonNull(this.getServiceEndpoint(), "serviceEndpoint is null"); | ||
| } catch (Exception e) { | ||
| throw new IllegalArgumentException( | ||
| String.format("Invalid VerificationMethod: %s", SerializeUtil.toJson(json)), e); |
There was a problem hiding this comment.
Why is the message mentioning an invalid verification method? Wouldn't it be more reasonable to note that the error comes from the service?
There was a problem hiding this comment.
Sure, this is certainly not correct. Fixed in 04a228d
borisrizov-zf
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementation of adding credential service to DID document
Closes: eclipse-tractusx/managed-identity-wallet#243
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: