Feat: new Exception system #44

koptan · 2023-11-07T14:41:46Z

To Fix #30, also some cleanup in the code.

BREAKING CHANGE: a lot of Exceptions have been added and removed, MIW needs to adopt the new changes.

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
Copyright and license header are present on all affected files

koptan · 2023-11-24T13:16:11Z

@borisrizov-zf please add @bjoern-arnold and @DominikPinsel as reviewer.

borisrizov-zf · 2023-12-06T08:46:56Z

@koptan We can begin the move after the 23.12 release. You'll have to do a rebase first.

koptan · 2023-12-06T12:38:37Z

@koptan We can begin the move after the 23.12 release. You'll have to do a rebase first.

This PR, will require some changes from MIW team, so I think it's better to talk to them and ask them to do the migration and test it from their side then we can do the merge.

@borisrizov-zf @DominikPinsel

borisrizov-zf · 2023-12-08T07:30:00Z

This PR is too large, we'll have to split it up to remain compliant. Let's plan the split next week.

bjoern-arnold

It would be better if InvalidPrivateKeyFormatException extend KeyGenerationException. This would eliminate the need to wrap the message in a KeyGenerationException and rethrow it.

bjoern-arnold

Creating an exception hierarchy with class KeyGenerationException as parent would be more elegant than wrapping and more specific exceptions in a KeyGenerationException and rethrowing it.
Also think about adding a "serialVerionUID" field to all exception classes (see JavaDoc for java.ioSerializable)

src/main/java/org/eclipse/tractusx/ssi/lib/crypt/x21559/x21559Generator.java

src/main/java/org/eclipse/tractusx/ssi/lib/exception/key/InvalidPublicKeyFormatException.java

src/main/java/org/eclipse/tractusx/ssi/lib/exception/key/InvalidPrivateKeyFormatException.java

...lipse/tractusx/ssi/lib/exception/resolver/DidDocumentResolverAlreadyRegisteredException.java

...g/eclipse/tractusx/ssi/lib/exception/resolver/DidDocumentResolverNotRegisteredException.java

src/main/java/org/eclipse/tractusx/ssi/lib/exception/resolver/DidWebException.java

src/main/java/org/eclipse/tractusx/ssi/lib/did/resolver/DidResolverException.java

src/main/java/org/eclipse/tractusx/ssi/lib/validation/JsonLdValidatorImpl.java

src/main/java/org/eclipse/tractusx/ssi/lib/jwt/SignedJwtVerifier.java

src/main/java/org/eclipse/tractusx/ssi/lib/proof/IVerifier.java

.../java/org/eclipse/tractusx/ssi/lib/exception/proof/SignatureVerificationFailedException.java

src/main/java/org/eclipse/tractusx/ssi/lib/exception/proof/JwtAudienceCheckFailedException.java

borisrizov-zf · 2024-01-25T07:27:06Z

@koptan please fix merge issues. Probably you need to just rebase.

BREAKING CHANGE: a lot of Exception has been added and removed

borisrizov-zf

Check the comments.

src/main/java/org/eclipse/tractusx/ssi/examples/Verification.java

src/main/java/org/eclipse/tractusx/ssi/lib/crypt/x21559/x21559PrivateKey.java

src/main/java/org/eclipse/tractusx/ssi/lib/crypt/x21559/x21559PublicKey.java

src/main/java/org/eclipse/tractusx/ssi/lib/exception/json/TransformJsonLdException.java

borisrizov-zf · 2024-01-31T13:13:48Z

src/main/java/org/eclipse/tractusx/ssi/lib/exception/key/InvalidPrivateKeyFormatException.java

+
+/** The type Invalide private key format. */
+public class InvalidPrivateKeyFormatException extends KeyGenerationException {
+  private static final long serialVersionUID = -3348735256693555408L;


Add the @Serial annotation
Make it equal 1L. as it's a new class
Repeat for all new Exception classes.

I think we need to use this compilation option javac -Xlint:serial to make it work, so I didn't change.

No, it's actually preferable to start at 1L and increment only when you've changed the class, in order to ensure serialization doesn't break between compilers, platforms and other outside factors. For exceptions it is sufficient to set it at 1L

.github/workflows/build.yaml

.github/workflows/publish-maven.yaml

.github/workflows/publish-snapshot-maven.yaml

docs/scripts/generateDoc.sh

docs/scripts/generateImages.sh

pom.xml

src/test/java/org/eclipse/tractusx/ssi/lib/util/identity/TestDidResolver.java

src/test/java/org/eclipse/tractusx/ssi/lib/util/identity/TestIdentity.java

src/test/java/org/eclipse/tractusx/ssi/lib/util/identity/TestIdentityTest.java

src/test/java/org/eclipse/tractusx/ssi/lib/validation/JsonLdValidatorTest.java

src/test/java/org/eclipse/tractusx/ssi/lib/verifiable/VerifiablePresentationTest.java

This reverts commit 74aeffa.

src/main/java/org/eclipse/tractusx/ssi/examples/Validation.java

src/main/java/org/eclipse/tractusx/ssi/lib/did/resolver/CompositeDidResolver.java

borisrizov-zf · 2024-02-09T10:26:32Z

@koptan I've done another sweep of the PR. It looks good, so as soon as you update the serialVersionUID we can finalize.

borisrizov-zf requested review from DominikPinsel and borisrizov-zf November 28, 2023 19:39

DominikPinsel approved these changes Dec 6, 2023

View reviewed changes

koptan mentioned this pull request Dec 6, 2023

fix: correcting typo Invalid in code #33

Closed

2 tasks

koptan closed this Dec 7, 2023

koptan force-pushed the issue-30-new-system-exception branch from 55fbfc0 to a3ecc34 Compare December 7, 2023 11:14

koptan reopened this Dec 7, 2023

bjoern-arnold suggested changes Dec 12, 2023

View reviewed changes

bjoern-arnold reviewed Dec 12, 2023

View reviewed changes

bjoern-arnold suggested changes Dec 12, 2023

View reviewed changes

koptan changed the title ~~feat: new Exception system~~ Feat: new Exception system Jan 9, 2024

borisrizov-zf assigned koptan Jan 16, 2024

bjoern-arnold approved these changes Jan 23, 2024

View reviewed changes

koptan and others added 6 commits January 31, 2024 13:38

feat: new Exception system

07dd0ea

BREAKING CHANGE: a lot of Exception has been added and removed

chore: Adding SerialVersion to all Exceptions

a6a2965

chore: Fixing code review

da82f77

Fix: Removed duplicate JsonLdValidator classes

ce0109f

fix: Throw exception and log in validation step

fd5fbb0

feat: new Exception system

9d6053a

BREAKING CHANGE: a lot of Exception has been added and removed

koptan force-pushed the issue-30-new-system-exception branch from faa875d to 9d6053a Compare January 31, 2024 12:57

borisrizov-zf requested changes Jan 31, 2024

View reviewed changes

Fix: Resolving comment review

74aeffa

koptan requested a review from borisrizov-zf February 1, 2024 10:26

borisrizov-zf requested changes Feb 2, 2024

View reviewed changes

.github/workflows/build.yaml Outdated Show resolved Hide resolved

borisrizov-zf requested changes Feb 5, 2024

View reviewed changes

koptan added 3 commits February 6, 2024 15:18

Revert "Fix: Resolving comment review"

1c8c822

This reverts commit 74aeffa.

fix: correcting from 21559 to 25519

fb477f9

koptan requested a review from borisrizov-zf February 6, 2024 14:47

borisrizov-zf requested changes Feb 6, 2024

View reviewed changes

src/main/java/org/eclipse/tractusx/ssi/examples/Validation.java Outdated Show resolved Hide resolved

src/main/java/org/eclipse/tractusx/ssi/lib/did/resolver/CompositeDidResolver.java Show resolved Hide resolved

koptan requested a review from borisrizov-zf February 6, 2024 15:33

fix: Fixing code review comments

8066e63

borisrizov-zf approved these changes Feb 20, 2024

View reviewed changes

borisrizov-zf merged commit cc049f0 into eclipse-tractusx:main Feb 20, 2024
3 checks passed

This was referenced Feb 23, 2024

Feat: adding Proof Configuration to Signature #77

Merged

Fix: Inconsistent initialization of Did #82

Closed

fix: integration test #86

Merged

Fix: Issue 43 - Produces wrong signatures #88

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: new Exception system #44

Feat: new Exception system #44

koptan commented Nov 7, 2023

koptan commented Nov 24, 2023 •

edited

Loading

borisrizov-zf commented Dec 6, 2023

koptan commented Dec 6, 2023 •

edited

Loading

borisrizov-zf commented Dec 8, 2023

bjoern-arnold left a comment •

edited

Loading

bjoern-arnold left a comment •

edited

Loading

borisrizov-zf commented Jan 25, 2024

borisrizov-zf left a comment

borisrizov-zf Jan 31, 2024

koptan Feb 1, 2024

borisrizov-zf Feb 7, 2024

borisrizov-zf commented Feb 9, 2024

Feat: new Exception system #44

Feat: new Exception system #44

Conversation

koptan commented Nov 7, 2023

Description

Pre-review checks

koptan commented Nov 24, 2023 • edited Loading

borisrizov-zf commented Dec 6, 2023

koptan commented Dec 6, 2023 • edited Loading

borisrizov-zf commented Dec 8, 2023

bjoern-arnold left a comment • edited Loading

Choose a reason for hiding this comment

bjoern-arnold left a comment • edited Loading

Choose a reason for hiding this comment

borisrizov-zf commented Jan 25, 2024

borisrizov-zf left a comment

Choose a reason for hiding this comment

borisrizov-zf Jan 31, 2024

Choose a reason for hiding this comment

koptan Feb 1, 2024

Choose a reason for hiding this comment

borisrizov-zf Feb 7, 2024

Choose a reason for hiding this comment

borisrizov-zf commented Feb 9, 2024

koptan commented Nov 24, 2023 •

edited

Loading

koptan commented Dec 6, 2023 •

edited

Loading

bjoern-arnold left a comment •

edited

Loading

bjoern-arnold left a comment •

edited

Loading