Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: support columns in ThreadStatusDataProvider tree model #179

Merged

Conversation

bhufmann
Copy link
Contributor

Do not merge until eclipse-cdt-cloud/theia-trace-extension#1149 is fixed.

Signed-off-by: Bernd Hufmann [email protected]

Add process ID (PID), parent PID (PPID) and thread ID (TID) columns as
part of the ThreadStatusDataProvider. This will be used in the trace
server.

[Added] PID, PPID and TID column in the ThreadStatusDataProvider tree

Signed-off-by: Bernd Hufmann <[email protected]>
Copy link
Contributor

@MatthewKhouzam MatthewKhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hesitant about exec, but it's everywhere in the kernel documentation.

@MatthewKhouzam
Copy link
Contributor

We can call exec process. If and only if you want.

@bhufmann
Copy link
Contributor Author

We can call exec process. If and only if you want.

The string Exec_name is used as label in other analysis and views (e.g. Scheuler Wakeup To Scheduler Switch Latency - Latency Table). I think it should be consistent across views.

image

@MatthewKhouzam
Copy link
Contributor

Approved!

@bhufmann bhufmann merged commit 1801704 into eclipse-tracecompass:master Nov 27, 2024
4 checks passed
@bhufmann bhufmann deleted the cfv_cololumns_data_provider branch November 27, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants