Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callstack: deprecate all classes that were moved to core #16

Merged

Conversation

arfio
Copy link
Contributor

@arfio arfio commented Apr 2, 2024

Deprecate all the classes from callstack and analysis that were moved to core. Change the classes that were not moved to depend on profiling.core and profiling.core.tests.
Dependent on #18 that will remove every dependency to these classes

@arfio arfio force-pushed the callstack-deprecated branch from 7e2aacc to 3d18df8 Compare April 4, 2024 18:14
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Trace Compass incubator project doesn't provide any releases, since it's an incubator project. However, we update the version number whenever Trace Compass mainline is released, just to have some tracking (even if it's not a release :-)).

So, currently it's at 0.9.0 and you will have to update all deprecated annotations to since="0.10.0". 9.4 is the Trace Compass mainline release and can't be used here. I commented only on 2 representative APIs to change. This comment is valid for all the others.

I noticed that the build is failing, because other plug-ins using deprecated APIs. This are settings that we chose for this project. You, could either change the setting or change the implementation to use the Trace Compass mainline APIs instead. I prefer the latter.

@@ -27,6 +27,7 @@
*
* @author Geneviève Bastien
*/
@Deprecated(since="9.4", forRemoval=true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.10.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -18,6 +18,7 @@
/**
* @author Geneviève Bastien
*/
@Deprecated(since="9.4", forRemoval=true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.10.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@arfio arfio force-pushed the callstack-deprecated branch from 3d18df8 to a53040f Compare April 10, 2024 17:16
@arfio
Copy link
Contributor Author

arfio commented Apr 10, 2024

Thank you for the review, I have changed the deprecation version argument like you suggested. For the other plug-ins using the deprecated API, I have another pull request opened for this: #18

@arfio arfio force-pushed the callstack-deprecated branch from a53040f to a6a1cf8 Compare April 12, 2024 15:38
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arfio To fix the build, change the settings for using deprecated APIs in ROCm plug-in to warning:

@arfio arfio force-pushed the callstack-deprecated branch from a6a1cf8 to ca10788 Compare April 16, 2024 13:33
@arfio arfio force-pushed the callstack-deprecated branch from ca10788 to 442cf37 Compare April 16, 2024 13:53
@arfio arfio requested a review from bhufmann April 16, 2024 16:20
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. Looks good to me.

@arfio arfio merged commit 2ffaa40 into eclipse-tracecompass-incubator:master Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants