Update Trace Event reader to handle stable diffusion traces #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewKhouzam
changed the title
bhufmann
requested changes
Dec 4, 2024
| if (tid instanceof Integer) { | ||
| return (Integer) tid; | ||
| } | ||
| if (tid != null) { |
There was a problem hiding this comment.
Not knowing the traces, in this case is tid a name or a number string? if it is a number string you could do parseInt() or something like that.
Add a comment why it's done like that.
There was a problem hiding this comment.
I think the new way is better.
Signed-off-by: Matthew Khouzam <[email protected]>
Store initial entries as properties. Signed-off-by: Matthew Khouzam <[email protected]>
Fix test, it was reading the wrong value before. Signed-off-by: Matthew Khouzam <[email protected]>
MatthewKhouzam
force-pushed
the
trace-event-stable-diffusion
branch
from
d389ef2 to
99d42a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pertains to lllyasviel/stable-diffusion-webui-forge#716
Depends on eclipse-tracecompass/org.eclipse.tracecompass#196