Return deleted data provider descriptor and related swagger doc updates #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
force-pushed
the
return_input_descriptor
branch
from
5e2b429 to
802c3d7
Compare
PatrickTasse
requested changes
Nov 4, 2024
| @@ -1326,11 +1326,11 @@ public Response createDataProvider( | |||
| @Tag(name = OCG) | |||
| @Produces(MediaType.APPLICATION_JSON) | |||
| @Operation(summary = "Delete a configuration instance of a given configuration type", responses = { | |||
| @ApiResponse(responseCode = "200", description = "The derived data provider (and it's configuration) was successfully deleted", content = @Content(schema = @Schema(implementation = org.eclipse.tracecompass.incubator.internal.trace.server.jersey.rest.core.model.Configuration.class))), | |||
| @ApiResponse(responseCode = "200", description = "Returns the deleted derived data provider descriptor. The derived data provider (and it's configuration) was successfully deleted.", content = @Content(schema = @Schema(implementation = DataProvider.class))), | |||
| @@ -1326,11 +1326,11 @@ public Response createDataProvider( | |||
| @Tag(name = OCG) | |||
| @Produces(MediaType.APPLICATION_JSON) | |||
| @Operation(summary = "Delete a configuration instance of a given configuration type", responses = { | |||
There was a problem hiding this comment.
Delete a derived data provider.
| @@ -1326,11 +1326,11 @@ public Response createDataProvider( | |||
| @Tag(name = OCG) | |||
There was a problem hiding this comment.
At line 1314, replace 'from created by' with 'created from'?
Also check the param and return tags.
bhufmann
force-pushed
the
return_input_descriptor
branch
2 times, most recently
from
9591df9 to
bddb954
Compare
bhufmann
force-pushed
the
return_input_descriptor
branch
2 times, most recently
from
ed0df37 to
db5a4f3
Compare
PatrickTasse
previously approved these changes
Nov 4, 2024
Update swagger description for deletion and corresponding method name. Signed-off-by: Bernd Hufmann <[email protected]>
Update also method name of the provider creation operation. Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
return_input_descriptor
branch
from
db5a4f3 to
697c889
Compare
PatrickTasse
approved these changes
Nov 4, 2024
bhufmann
merged commit ddb176a
into
eclipse-tracecompass-incubator:master
2 checks passed
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update swagger description for deletion and method name.
Update also method name.
Signed-off-by: Bernd Hufmann [email protected]