Checking for @type being an array
#599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thingweb-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Gotten a bit rusty and made some mistakes... Will refactor :) |
| return "td"; | ||
| } | ||
| } else { | ||
| // then it is an array |
There was a problem hiding this comment.
Wouldn't it be better to check for array?
| /** | ||
| * Checks if the input is a TD or TM | ||
| * @param {jsonDocument} | ||
| * @returns "tm" or "td" |
There was a problem hiding this comment.
Would it make sense to report a unknown value also so the caller can decide what it is defaulting to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #598