Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New examples feel sergio #540

Merged

Conversation

SergioCasCeb
Copy link
Contributor

  • Changed the example design to somehow resemble the Gmail style
  • Added a drop-down arrow to specify that the examples can be expanded
  • The quick-use button is now hidden until the user hovers over the example
  • This new design also allows to reduce the spacing of the example card even further

The size and spacing of the examples has been reduced, to provide a better look and feel
- Changed the examples design to somehow resemble gmail
- Added a drop down arrow to specified that the examples can be expanded
- The quick use icon is only visible when hovering over the example
Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for thingweb-playground ready!

Name Link
🔨 Latest commit 1ee98da
🔍 Latest deploy log https://app.netlify.com/sites/thingweb-playground/deploys/65772945fe3ce2000877dafc
😎 Deploy Preview https://deploy-preview-540--thingweb-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@egekorkan
Copy link
Member

The downwards arrow is sometimes hidden by the use button when it shows up. It happens when the example name is too short, I think.

@SergioCasCeb
Copy link
Contributor Author

@egekorkan, yes I have added a type of spacing to provide a more clean visible icon, without having it clash with the title, similar to how Gmail hides a part of the text when hovering on an email to show the extra icons. As you mentioned though this does hide the arrow icon when the title is too long.

If this is not the desirable approach, I can either:

  • Reduce or crop the actual text of the title
  • Already have some extra space on the card to account for the icon, though this will make the cards longer.

@egekorkan
Copy link
Member

similar to how Gmail hides a part of the text when hovering on an email to show the extra icons.

Yes but that is clear to the user as just some part of the text disappears and the text is not a clickable element. Here, we actually lose functionality.

Already have some extra space on the card to account for the icon, though this will make the cards longer.

I like this more. The difference should be minimal :)

Copy link
Member

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged once the conflicts are resolved

@egekorkan egekorkan merged commit ef25c6a into eclipse-thingweb:master Dec 11, 2023
7 of 10 checks passed
@SergioCasCeb SergioCasCeb deleted the new-examples-feel-sergio branch December 13, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants