-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New examples feel sergio #540
New examples feel sergio #540
Conversation
SergioCasCeb
commented
Dec 6, 2023
- Changed the example design to somehow resemble the Gmail style
- Added a drop-down arrow to specify that the examples can be expanded
- The quick-use button is now hidden until the user hovers over the example
- This new design also allows to reduce the spacing of the example card even further
The size and spacing of the examples has been reduced, to provide a better look and feel
- Changed the examples design to somehow resemble gmail - Added a drop down arrow to specified that the examples can be expanded - The quick use icon is only visible when hovering over the example
✅ Deploy Preview for thingweb-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The downwards arrow is sometimes hidden by the use button when it shows up. It happens when the example name is too short, I think. |
@egekorkan, yes I have added a type of spacing to provide a more clean visible icon, without having it clash with the title, similar to how Gmail hides a part of the text when hovering on an email to show the extra icons. As you mentioned though this does hide the arrow icon when the title is too long. If this is not the desirable approach, I can either:
|
Yes but that is clear to the user as just some part of the text disappears and the text is not a clickable element. Here, we actually lose functionality.
I like this more. The difference should be minimal :) |
- Modified the cards to account for the hidden use icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged once the conflicts are resolved