Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed "share url" pop up functionality #486

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Changed "share url" pop up functionality #486

merged 1 commit into from
Aug 3, 2023

Conversation

SergioCasCeb
Copy link
Contributor

  • Removed the clipboard functionality to address the browser support issues
  • Share URL text now adapts depending if the document is a TD or a TM
  • Introduced a new button that enables users to effortlessly open the generated URL in another playground tab

egekorkan
egekorkan approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work and much cleaner.

@egekorkan egekorkan merged commit 0acd2fc into eclipse-thingweb:master Aug 3, 2023
8 checks passed
@egekorkan egekorkan mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egekorkan egekorkan egekorkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioCasCeb @egekorkan