Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binding_coap): add support for PEM root certificates #207

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Dec 12, 2024

This PR adds some improvements to the handling of DTLS within the CoAP binding. To be able to merge this PR, a new version of the coap package has to be released first, therefore I am keeping this one a draft for now.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.23%. Comparing base (b180edb) to head (c3c1e5f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/binding_coap/coap_client.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   63.26%   63.23%   -0.03%     
==========================================
  Files          79       79              
  Lines        2311     2312       +1     
==========================================
  Hits         1462     1462              
- Misses        849      850       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb marked this pull request as ready for review December 13, 2024 15:28
@JKRhb
Copy link
Member Author

JKRhb commented Dec 13, 2024

As a new version of coap as been released in the meantime, this one can be merged now :)

@JKRhb JKRhb enabled auto-merge December 13, 2024 15:28
@JKRhb JKRhb merged commit 0dc118e into main Dec 13, 2024
5 checks passed
@JKRhb JKRhb deleted the pem-certificates branch December 13, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants