feat!: move discovery configurations to scripting_api package #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 63.38% 63.30% -0.08%
==========================================
Files 78 78
Lines 2272 2273 +1
==========================================
- Hits 1440 1439 -1
- Misses 832 834 +2 ☔ View full report in Codecov by Sentry. |
JKRhb
force-pushed
the
discovery-configuration
branch
2 times, most recently
from
9c11c6e to
8463b10
Compare
JKRhb
force-pushed
the
discovery-configuration
branch
from
8463b10 to
bcac81f
Compare
|
I think this PR should now be ready to be merged and to potentially serve as the basis for future discussions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of the recent discussion in the Scripting API repo, I realized that it probably makes more sense to pass the configurations for the
discovermethod to the method itself, instead of setting them via the underlyingServient.As there is still an ongoing discussion in the Scripting API taskforce, I labelled the changes as experimental, as there will probably be additional changes (that might lead to a totally different API than the one that is currently in place) as we go along.