feat!: implement proper serialization logic #178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, there hasn't been a proper serialization implementation in place, which has been a major obstacle for adding ExposedThing functionality to the package. This PR changes that, making it possible to convert a Thing Description into a JSON (or CBOR) object.
The go-to approach for this kind of task in the Dart ecosystem is probably the
json_serializable
package. However, it seemed to me as if the annotation-based approach which is commonly used by that package (which also involves a generation step that I really dislike) is a bit too inflexible for the TD data model.After the merge of this PR and maybe once the json_serializable has switched to using the new macros in the Dart language instead of their conventional builder-approach, we could consider replacing the (in some places somewhat inelegant implementation) with a nicer one that is close to the state of the art.