feat!: rework discoverer APIs #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 66.66% 66.20% -0.47%
==========================================
Files 77 78 +1
Lines 2439 2459 +20
==========================================
+ Hits 1626 1628 +2
- Misses 813 831 +18 ☔ View full report in Codecov by Sentry. |
JKRhb
force-pushed
the
discovery-interfaces
branch
from
2cb0222 to
0577643
Compare
JKRhb
force-pushed
the
discovery-interfaces
branch
4 times, most recently
from
b4b9a32 to
bcf6984
Compare
JKRhb
force-pushed
the
discovery-interfaces
branch
from
13fd5d5 to
3ef8646
Compare
JKRhb
force-pushed
the
discovery-interfaces
branch
from
3ef8646 to
44bb791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a (partially experimental) reimplementation of the different discovery methods that are currently available.
Some of the most important changes include the addition of a dedicated discovery method for MQTT (since it does not really fall into the other forms of “direct” discovery) and the introduction of mixins that can be used to indicate which discovery methods a
ProtocolClientsupports.These and other aspects related to discovery could be discussed in one of the upcoming committer meetings, which is why I added this PR to the Committer Meeting project.
Lastly, during the implementation, I've noticed that there is a bug in the CoAP library that causes multicast requests to not be properly sent. This probably requires a fix in the upstream dependency.