Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(analysis_options.yaml): report warnings for missing documentation #163

Merged
merged 1 commit into from
May 24, 2024

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented May 24, 2024

Since (almost) 100% of the public API members have documentation provided, this PR enforces the addition of new documentation a bit more strictly by reporting a warning instead of an info message if no doc comment should be provided.

This could even be changed to an error later if the API should become completely stable; however, as the development process is still ongoing, that step is probably a bit too much at the moment.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.74%. Comparing base (181ab01) to head (5b56ce2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   66.69%   66.74%   +0.05%     
==========================================
  Files          77       77              
  Lines        2438     2436       -2     
==========================================
  Hits         1626     1626              
+ Misses        812      810       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb force-pushed the missings-docs-error branch from 11667d5 to ffa2d39 Compare May 24, 2024 10:56
@JKRhb JKRhb force-pushed the missings-docs-error branch from e7fee87 to 5b56ce2 Compare May 24, 2024 10:58
@JKRhb JKRhb marked this pull request as ready for review May 24, 2024 10:58
@JKRhb JKRhb enabled auto-merge May 24, 2024 10:58
@JKRhb JKRhb merged commit 3bd7c78 into main May 24, 2024
5 checks passed
@JKRhb JKRhb deleted the missings-docs-error branch May 24, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants