Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework clean up of ConsumedThing #162

Merged
merged 4 commits into from
May 24, 2024
Merged

Rework clean up of ConsumedThing #162

merged 4 commits into from
May 24, 2024

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented May 24, 2024

This PR reworks the relationship between Servient, ConsumedThing, and the Subscriptions created when observing a property or subscribing to an event. It also removes the ConsumedThing cleanup code from the Servient class, which is not needed anymore now.

These changes decrease the coupling between the different parts of the codebase, making it overall more maintainable.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 66.74%. Comparing base (37fbb28) to head (aab9e9b).

Files Patch % Lines
lib/src/core/implementation/consumed_thing.dart 0.00% 12 Missing ⚠️
...ore/protocol_interfaces/protocol_subscription.dart 0.00% 3 Missing ⚠️
lib/src/binding_coap/coap_subscription.dart 0.00% 1 Missing ⚠️
lib/src/binding_mqtt/mqtt_subscription.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   66.36%   66.74%   +0.38%     
==========================================
  Files          76       77       +1     
  Lines        2453     2436      -17     
==========================================
- Hits         1628     1626       -2     
+ Misses        825      810      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb force-pushed the refactor-structure branch 2 times, most recently from 0904ca2 to 373522e Compare May 24, 2024 10:13
@JKRhb JKRhb force-pushed the refactor-structure branch 3 times, most recently from 9ce825b to 89c5672 Compare May 24, 2024 10:35
@JKRhb JKRhb marked this pull request as ready for review May 24, 2024 10:40
@JKRhb JKRhb force-pushed the refactor-structure branch from 9034026 to aab9e9b Compare May 24, 2024 10:42
@JKRhb JKRhb enabled auto-merge May 24, 2024 10:43
@JKRhb JKRhb merged commit 9255bea into main May 24, 2024
5 checks passed
@JKRhb JKRhb deleted the refactor-structure branch May 24, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants