Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for array types was requested in issue #317 and its implementation recently merged into develop (PR #340).
However, there were a few issues with it.
I will try and summarize what this PR addresses.
int and float array types:
it fails to decode int and float arrays (other than
Int8Array
andUint8Array
): an array of the right size is returned, but it is filled with the first value from the original array.This is because the decoding function always returns the first byte (index 0) regardless of how it is invoked (
i
has no effect on these calls).boolean array type:
It fails here with the following error
byte length of Uint32Array should be a multiple of 4
.And I believe the bytes would then be built with bits reversed.