Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unboard train's passengers through doors when the rail line is curved (#14334) #14336

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

bcoueraud87
Copy link
Contributor

No description provided.

@bcoueraud87 bcoueraud87 changed the title Unboard train's passengers through doors when the rail line is curved (#14334 Unboard train's passengers through doors when the rail line is curved (#14334) Feb 15, 2024
@namdre
Copy link
Contributor

namdre commented Feb 16, 2024

can you explain why an existing test changed it's behavior? The rail line in that test is not curved and also the door attribute isn't used in the scenario.

@bcoueraud87
Copy link
Contributor Author

bcoueraud87 commented Feb 16, 2024

The test I adapted uses doors, look at the input_routes.rou.xml file:

<additional xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://sumo.dlr.de/xsd/additional_file.xsd">
    <busStop id="B" lane="a_0" startPos="30" endPos="70">
        <access lane="b_0" pos="48.40"/>
    </busStop>
    <busStop id="C" lane="a_0" startPos="230" endPos="270">
        <access lane="c_0" pos="52.96"/>
    </busStop>
    <busStop id="D" lane="a_0" startPos="430" endPos="470">
        <access lane="d_0" pos="doors"/>
    </busStop>
</additional>

Now, it is true that in this test the rail line is not curved, however, even in the straight case, the computations are now a little bit different.

@namdre
Copy link
Contributor

namdre commented Feb 16, 2024

Sorry, I missed f9b6e68 even though you linked it in #14336 and mistook the test for another one I knew.

@namdre namdre merged commit 94dc056 into eclipse-sumo:main Feb 16, 2024
45 of 47 checks passed
behrisch added a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants