Fixes regression in #12990 #13740
Merged
Fixes regression in #12990 #13740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
|
Sorry for not looking at this one earlier. There was a lot of empty line removal which is something astyle does not (at least on our side) Could you please revert this if possible? |
Signed-off-by: Max <[email protected]>
|
I removed whitespace / newline changes to the best of my ability |
|
Thanks for the reminder ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of red transfer in #12990 led to edge cases where illegal barrier cross could occur. The problem was incorrect transition time calculation for lights in red transfer state.
I simplified the red transfer logic and corrected the error in transition time calculation for phases in red transfer (
0)PR also includes refactoring & ran
astyle.