finally fixing memory leak fix #14034

eclipse-sumo · Nov 11, 2023 · 456d294 · 456d294
1 parent 4c0fd85
commit 456d294
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/router/ROPerson.cpp b/src/router/ROPerson.cpp
@@ -416,13 +416,13 @@ ROPerson::computeRoute(const RORouterProvider& provider,
                     }
                     if (cost < bestCost) {
                         bestCost = cost;
-                        while (!best.empty()) {
-                            delete best.back();
-                            best.pop_back();
-                        }
-                        best.swap(resultItems);
                         bestVeh = carUsed ? v : nullptr;
+                        best.swap(resultItems);
+                    }
+                    for (TripItem* const it : resultItems) {
+                        delete it;
                     }
+                    resultItems.clear();
                 }
             }
             trip->setItems(best, bestVeh);