Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4359] Fix an issue where two pagination forms where display in tables #4361

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[4359] Fix an issue where two pagination forms where display in tables #4361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ This may have some consequences for downstream applications which are embedding
- https://github.com/eclipse-sirius/sirius-web/issues/3578[#3578] [diagram] Fix tooltip and menu visibility in a full screen mode.
See https://github.com/mui/material-ui/issues/15618[this link] for additional details.
- https://github.com/eclipse-sirius/sirius-web/issues/4360[#4360] [table] Prevent application crash when opening tables from a form
- https://github.com/eclipse-sirius/sirius-web/issues/4359[#4359] [table] Fix an issue where two pagination forms where display in tables


=== New Features
Expand All @@ -57,7 +58,6 @@ See https://github.com/mui/material-ui/issues/15618[this link] for additional de
Specifiers can contribute dedicated AQL services for this feature using implementations of `IInterpreterJavaServiceProvider`
- https://github.com/eclipse-sirius/sirius-web/issues/4346[#4346] [core] The field `Object#iconURLs` has been added to the GraphQL schema in order to retrieve the icon of an object
- https://github.com/eclipse-sirius/sirius-web/issues/4346[#4346] [query] Add some feedback for long running evaluations
Specifiers can contribute dedicated AQL services for this feature using implementations of `IInterpreterJavaServiceProvider`.
- https://github.com/eclipse-sirius/sirius-web/issues/4338[#4338] [core] A Spring log group dedicated to performance issues has been created.
As a result, one can use `logging.level.sirius.web.performance=DEBUG` in order to display key performance metrics in a Sirius Web instance.
Some log messages have been updated in order to provide more information and make them easier to read to idenfity key performance issues.
Expand Down
4 changes: 2 additions & 2 deletions packages/tables/frontend/sirius-components-tables/src/table/TableContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2024 Obeo.
* Copyright (c) 2024, 2025 Obeo.
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v2.0
* which accompanies this distribution, and is available at
Expand Down Expand Up @@ -147,7 +147,7 @@ export const TableContent = memo(
enableEditing: !readOnly,
onColumnFiltersChange: setColumnFilters,
enableStickyHeader: true,
enablePagination,
enablePagination: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a mistake from my part when I merged one of your PRs before -.-

manualPagination: enablePagination,
rowCount: table.paginationData.totalRowCount,
enableRowActions: true,
Expand Down
Loading