Skip to content

Commit

Permalink
[4137] Do not unload EMF resources when disposing an editing context
Browse files Browse the repository at this point in the history
Bug: #4137
Signed-off-by: Pierre-Charles David <[email protected]>
  • Loading branch information
pcdavid committed Oct 25, 2024
1 parent e2c6172 commit f483904
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ This will allow specifier to create images that fir perfectly in the project tem
- https://github.com/eclipse-sirius/sirius-web/issues/2163[#2163] [form] Make EMF default form support non changeable features
- https://github.com/eclipse-sirius/sirius-web/issues/4086[#4086] [form] Wrap widget returned by property section in a div with a specific classname
- https://github.com/eclipse-sirius/sirius-web/issues/4088[#4088] Change tree item context menu entries internal management

- https://github.com/eclipse-sirius/sirius-web/issues/4137[#4137] [emf] EMF Resources are no longer unloaded when disposing an editing context.
This avoids a costly conversion of all `EObjects` into proxies at a time when we know they will not be used anymore anyway.

== v2024.9.0

Expand Down
4 changes: 2 additions & 2 deletions packages/emf/backend/sirius-components-emf/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@
<artifactId>gson</artifactId>
</dependency>
<dependency>
<groupId>org.eclipse.sirius.emfjson</groupId>
<groupId>org.eclipse.sirius</groupId>
<artifactId>org.eclipse.sirius.emfjson</artifactId>
<version>2.3.12-SNAPSHOT</version>
<version>2.4.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
*******************************************************************************/
package org.eclipse.sirius.components.emf.services.api;

import org.eclipse.emf.ecore.resource.Resource;
import org.eclipse.emf.edit.domain.AdapterFactoryEditingDomain;
import org.eclipse.sirius.components.core.api.IEditingContext;

Expand All @@ -32,6 +31,5 @@ public interface IEMFEditingContext extends IEditingContext {

@Override
default void dispose() {
this.getDomain().getResourceSet().getResources().forEach(Resource::unload);
}
}

0 comments on commit f483904

Please sign in to comment.