[4360] Fix an issue when opening tables from a form

Bug: #4360 Signed-off-by: Florian ROUËNÉ <[email protected]>
eclipse-sirius · Jan 3, 2025 · 5a914b0 · 5a914b0
1 parent a7c6b22
commit 5a914b0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc
@@ -22,6 +22,7 @@ The `start` task used in our turbo configuration is now marked as `persistent` a
 
 === Bug fixes
 
+https://github.com/eclipse-sirius/sirius-web/issues/4360[#4360] [table] Prevent application crash when opening tables from a form
 
 === New Features
 

diff --git a/packages/tables/frontend/sirius-components-tables/src/columns/useTableColumnFiltering.ts b/packages/tables/frontend/sirius-components-tables/src/columns/useTableColumnFiltering.ts
@@ -81,7 +81,7 @@ export const useTableColumnFiltering = (
 
   if (!enableColumnFilters) {
     return {
-      columnFilters: undefined,
+      columnFilters: [],
       setColumnFilters: undefined,
     };
   }

diff --git a/...ges/tables/frontend/sirius-components-tables/src/columns/useTableColumnFiltering.types.ts b/...ges/tables/frontend/sirius-components-tables/src/columns/useTableColumnFiltering.types.ts
@@ -16,8 +16,9 @@ import { MRT_ColumnFiltersState } from 'material-react-table';
 export type ColumnFilterSetter = (
   columnFilters: MRT_ColumnFiltersState | ((prevState: MRT_ColumnFiltersState) => MRT_ColumnFiltersState)
 ) => void;
+
 export interface UseTableColumnFilteringValue {
-  columnFilters: MRT_ColumnFiltersState | undefined;
+  columnFilters: MRT_ColumnFiltersState;
   setColumnFilters: ColumnFilterSetter | undefined;
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -22,6 +22,7 @@ The `start` task used in our turbo configuration is now marked as `persistent` a

		=== Bug fixes

		https://github.com/eclipse-sirius/sirius-web/issues/4360[#4360] [table] Prevent application crash when opening tables from a form

		=== New Features

Expand Down