Skip to content

Commit

Permalink
[1062] Allow expand/collapse of tree items without selecting them
Browse files Browse the repository at this point in the history
This was originally fixed in 2022.3.0 via commit
48913d1, but broken again in
2024.3.0.

This reverts "[3056] Expand the clickable/draggable zone for tree
items" (commit 190b919) which caused
the regression.

Bug: #1062
Signed-off-by: Pierre-Charles David <[email protected]>
  • Loading branch information
pcdavid committed Nov 18, 2024
1 parent e98f7ee commit 250022b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@

=== Bug fixes


- https://github.com/eclipse-sirius/sirius-web/issues/1062[#1062] [explorer] It is now possible to expand or collapse items in the explorer without selecting them by clicking directly on the expand/collapse arrow icon.
This was first fixed in 2022.3.0 but broken in 2024.3.0; it is now fixed again.

=== New Features

Expand Down Expand Up @@ -144,7 +145,6 @@ Charts' metadata is only relevant when Charts are used as Representations.
- https://github.com/eclipse-sirius/sirius-web/issues/4154[#4154] [diagram] Restore feedback while resizing a list container
- https://github.com/eclipse-sirius/sirius-web/issues/4141[#4141] [sirius-web] Fix a bug where opening a representation from its URL or from the onboarding area no longer revealed it in the Explorer view.


=== New Features

- https://github.com/eclipse-sirius/sirius-web/issues/3763[#3763] [diagram] Make it possible to display semantic candidates in the selection dialog using a tree
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,7 @@ export const TreeItem = ({
/>
<div
className={className}
draggable={true}
onClick={onClick}
onDragStart={dragStart}
onDragOver={dragOver}
onDragEnter={() => handleMouseEnter('item')}
onDragExit={handleMouseLeave}
onDrop={onDropItem}
Expand All @@ -363,6 +360,10 @@ export const TreeItem = ({
ref={refDom}
tabIndex={0}
onKeyDown={onBeginEditing}
draggable={true}
onClick={onClick}
onDragStart={dragStart}
onDragOver={dragOver}
data-treeitemid={item.id}
data-treeitemlabel={label}
data-treeitemkind={item.kind}
Expand Down

0 comments on commit 250022b

Please sign in to comment.