Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ecf.filetransfer.httpclient5 in SimRel #57

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jonahgraham
Copy link
Contributor

This is to workaround:

And to enable:

in 2023-12 M3.

The Eclipse Platform is expected to contribute this for RC1 but including this from ECF allows us to start testing this in 2023-12 M3

This is to workaround:

- eclipse-equinox/p2#381

And to enable:

- eclipse-packaging/packages#81

in 2023-12 M3.

The Eclipse Platform is expected to contribute this for RC1
but including this from ECF allows us to start testing this
in 2023-12 M3
@jonahgraham
Copy link
Contributor Author

@merks WDYT? Is this useful to workaround this comment you made in eclipse-equinox/p2#381 (comment)

Yes I think so. We will have to hold off until rc1 because it probably breaks m3 disabling the only provider. And we should consider a future where we maybe need a touch point to remove it.

I will do more testing with the installer tomorrow.

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now! So you will include the feature in SimRel so that you can include it in the products for m3 so that we can do earlier testing of the option to disable the other provider.

@jonahgraham
Copy link
Contributor Author

Yes, thanks Ed for the review.

@jonahgraham jonahgraham merged commit 5dffc95 into eclipse-simrel:main Nov 14, 2023
2 checks passed
@jonahgraham jonahgraham deleted the ecf branch November 14, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants