Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1596: [Win32] Drawing produces unsymmetric results without swt.autoScale=false for 4k monitor with zooming #1607

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tmssngr
Copy link
Contributor

@tmssngr tmssngr commented Nov 21, 2024

When drawing a vertical line at x == 1 with 200% zoom level (HiDPI),
MacOS draws it on the physical pixel coordinates 2 and 3 while on
Windows (with the existing code) it was drawn at 1 and 2.

In other words: the existing code drew lines 1 pixel too far left/top.
This commit should resolve this.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Test Results

   382 files   -   101     382 suites   - 101   8m 8s ⏱️ -30s
 4 060 tests  -    35   4 049 ✅  -    36   6 💤  -  1  5 ❌ +2 
12 112 runs   - 4 061  12 066 ✅  - 4 014  41 💤  - 49  5 ❌ +2 

For more details on these failures, see this check.

Results for commit bd0b255. ± Comparison against base commit 266cc26.

This pull request removes 35 tests.
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testTextTransfer
…
This pull request skips 2 tests.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_Constructor_multipleInstantiationsInDifferentThreads[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Button ‑ test_traverseCheckButton

♻️ This comment has been updated with latest results.

Thomas Singer added 2 commits November 26, 2024 11:46
…ithout swt.autoScale=false for 4k monitor with zooming

When drawing a vertical line at x == 1 with 200% zoom level (HiDPI),
MacOS draws it on the physical pixel coordinates 2 and 3 while on
Windows (with the existing code) it was drawn at 1 and 2.

In other words: the existing code drew lines 1 pixel too far left/top.
This commit should resolve this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant