Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge: properly handle initialization failures and abortion #1578

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Edge: properly handle initialization failures and abortion #1578

wants to merge 1 commit into from
+44 −18

Conversation

HeikoKlare
Copy link
Contributor

There is currently only few handling for failures during initialization of an Edge browser / WebView instance. The Microsoft documentation provides further information on this, in particular:

  • ERROR_INVALID_STATE indicates that multiple Edge instances with the same data folder but different environment options exist
  • E_ABORT indicates an active abortion of the initialization process
  • On any other non-OK return value than the above ones, the app should retry initialization of the instance

This change adds appropriate handling for these scenarios, consisting of uniform rollback logic when the initialization fails or is aborted and retry logic to make repeated creation attempts.

Experimental: for testing purposes this PR currently also enables the browser tests for Edge.

@HeikoKlare
Edge: properly handle initialization failures and abortion
86c452d 
There is currently only few handling for failures during initialization
of an Edge browser / WebView instance. The Microsoft documentation
provides further information on this, in particular:
- ERROR_INVALID_STATE indicates that multiple Edge instances with the
same data folder but different environment options exist
- E_ABORT indicates an active abortion of the initialization process
- On any other non-OK return value than the above ones, the app should
retry initialization of the instance

This change adds appropriate handling for these scenarios, consisting of
uniform rollback logic when the initialization fails or is aborted and
retry logic to make repeated creation attempts.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Test Results

   481 files   -   2     481 suites   - 2   7m 59s ⏱️ - 1m 35s
 4 060 tests  -  35   4 052 ✅  -  33   5 💤  - 2  3 ❌ ±0 
15 949 runs   - 224  15 862 ✅  - 218  84 💤  - 6  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 86c452d. ± Comparison against base commit c39b59c.

This pull request removes 35 tests. 
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testTextTransfer
…
This pull request skips 1 test. 
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_Constructor_multipleInstantiationsInDifferentThreads[browser flags: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HeikoKlare