Refactor Image for storing ImageMetadata #1496
Merged
+420
−452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 483 files ±0 483 suites ±0 9m 33s ⏱️ +40s For more details on these failures, see this check. Results for commit 7f5b4d4. ± Comparison against base commit a6b8fe7. ♻️ This comment has been updated with latest results. |
amartya4256
force-pushed
the
imageMetadata
branch
from
68e8193
to
597c46d
Compare
amartya4256
force-pushed
the
imageMetadata
branch
from
597c46d
to
9acf71a
Compare
amartya4256
force-pushed
the
imageMetadata
branch
2 times, most recently
from
3832a24
to
e353b1a
Compare
akoch-yatta
reviewed
Oct 9, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
imageMetadata
branch
3 times, most recently
from
8067b98
to
6225eae
Compare
fedejeanne
force-pushed
the
imageMetadata
branch
from
6225eae
to
8f0c350
Compare
|
Converted it back to Draft, this one should be merged in 4.35 M1 |
amartya4256
force-pushed
the
imageMetadata
branch
2 times, most recently
from
689b931
to
42db14c
Compare
fedejeanne
reviewed
Nov 12, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
imageMetadata
branch
6 times, most recently
from
ea52af4
to
5d4076a
Compare
akoch-yatta
force-pushed
the
imageMetadata
branch
from
5d4076a
to
83bd8d7
Compare
fedejeanne
force-pushed
the
imageMetadata
branch
from
83bd8d7
to
6baebb4
Compare
This contribution encapsulates the metadata of the image in an innerclass ImageHandle which is used to create a hashmap of zoom level to imageHandle object inside an image object, making it straight forward to obtain any metadata information from an image for a zoom level. contributes to eclipse-platform#62 and eclipse-platform#127
fedejeanne
force-pushed
the
imageMetadata
branch
from
6baebb4
to
7f5b4d4
Compare
|
The build is failing when trying to commit the newly generated SWT Binaries here: And the tag definitely exists, it was created 1 hour ago --> https://github.com/eclipse-platform/eclipse.platform.swt/releases/tag/v4968r1. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to the refactoring of
Imageclass for win32.The goal is to store more than just the
handleof the image for each zoom level. To do that, a new private class is created (it's calledImageHandle) and an image contains one instance of this new class for each zoom level. The class contains the following fields:handleheightwidthcontributes to #62 and #127