Update to Tycho 4.0.10-SNAPSHOT

[HeikoKlare]

Update to current snapshot version of Tycho in order to:

• Fix issues with SWT builds that came up with Tycho 4.0.9 and required SWT to move back to Tycho 4.0.8
• Test recent Tycho changes with Eclipse platform before releasing Tycho version

Also see eclipse-platform/eclipse.platform.swt#1488 (comment)

[laeubi]

Should also with API errors @HannesWell by using the new

• [tycho-4.0.x] Add new option to API tools verify goal to runAsJob eclipse-tycho/tycho#4406

instead of rely on the old api-tools, that should also be considered here!

[HeikoKlare]

Should also with API errors @HannesWell by using the new

• [tycho-4.0.x] Add new option to API tools verify goal to runAsJob eclipse-tycho/tycho#4406

instead of rely on the old api-tools, that should also be considered here!

@laeubi can you explain how we need to consider this here? So is there any further change required in the aggregator or will there be some implicit effect by that change that we may experience when updating Tycho here?

[laeubi]

For example here:

eclipse.platform.releng.aggregator/eclipse-platform-parent/pom.xml

Line 924 in cd58890

<version>4.0.8</version>

and previously there where some deadlocks so maybe one wants to use <runAsJob>false</runAsJob>

beside that there is already something like https://tycho.eclipseprojects.io/doc/latest/tycho-extras/tycho-p2-extras-plugin/mirror-mojo.html#includeFeatures so we could maybe even have an includeCategories option.

[HeikoKlare]

For example here:

eclipse.platform.releng.aggregator/eclipse-platform-parent/pom.xml

Line 924 in cd58890

<version>4.0.8</version>

and previously there where some deadlocks so maybe one wants to use <runAsJob>false</runAsJob>

I missed that one, so I just adapted the Tycho version used for API tools to the one defined via property. In order to avoid the issues that had been resolved/worked around via #2380, I also set runAsJob=false.

beside that there is already something like https://tycho.eclipseprojects.io/doc/latest/tycho-extras/tycho-p2-extras-plugin/mirror-mojo.html#includeFeatures so we could maybe even have an includeCategories option.

I have to admit that I don't understand what this means.

[laeubi]

I have to admit that I don't understand what this means.

Than means I posted the comment on the wrong issue :-\

[HannesWell]

For example here:

eclipse.platform.releng.aggregator/eclipse-platform-parent/pom.xml

Line 924 in cd58890

<version>4.0.8</version>

and previously there where some deadlocks so maybe one wants to use <runAsJob>false</runAsJob>

I missed that one, so I just adapted the Tycho version used for API tools to the one defined via property. In order to avoid the issues that had been resolved/worked around via #2380, I also set runAsJob=false.

Yes exactly, that's the right thing to do.
Thanks for pushing this forward, looks good to me. Let's have this rather earlier than later.

[HeikoKlare]

@HannesWell @laeubi I just had this failure in a Platform UI build with the new Tycho version:

Error:  Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10-SNAPSHOT:verify (verify) on project org.eclipse.e4.core.commands: Execute ApiApplication failed: InvocationTargetException: Component 'Eclipse e4 core commands' in the baseline 'workspace' is disposed [main]: Component was disposed here [Worker-1: Updating plug-in dependencies] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10-SNAPSHOT:verify (verify) on project org.eclipse.e4.core.commands: Execute ApiApplication failed

This is because of not running the API analysis as job, i.e., with <runAsJob>false</runAsJob>, is it? So, is that really the right thing to do? I cannot remember that we had these kinds of failures in the past months.

[laeubi]

This is because of not running the API analysis as job, i.e., with false, is it?

I think so yes, but until now its not possible to reproduce it reliable enough.

So, is that really the right thing to do?

If it is enabled it seem to lead to some deadlocks sometimes, so we decided to better sometimes fail than sometimes deadlock :-)

I cannot remember that we had these kinds of failures in the past months.

I have seen it a few times and that's why I introduced the usage of a job.

[HeikoKlare]

Okay, then maybe I was just lucky in the past weeks, because I had the impression that switching back to Tycho 4.0.8 for the API tools (#2380) had resolved that issue. In the recent Platform UI builds, 2 of the 4 execution (3 x GH Actions + 1 x Jenkins) failed, most recently in this: https://github.com/eclipse-platform/eclipse.platform.ui/actions/runs/11743599414/job/32716818845?pr=2507

Let's see how builds behave in the next days.

[laeubi]

I think it would be interesting to get a Threadump of the deadlock but at the moment I'm only aware of a lockdown on the buildservers and it seems one need admin permission to do so ( @fredg02 ) according to this:
https://www.jenkins.io/doc/book/troubleshooting/obtaining-a-thread-dump/