Move more product configuration from p2.inf to product-file #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonahgraham do you want to have a look at this? |
jonahgraham
approved these changes
Nov 7, 2023
|
I cannot submit right now because of branch protection rule. See https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3921#note_1321711 |
And remove the unnecessary specification of the property org.eclipse.equinox.p2.type.product=true, which Tycho/P2 already set by default.
jonahgraham
force-pushed
the
config-to-product
branch
from
6f9a00a
to
6b6a2bd
Compare
|
I rebased this on current master and that forced the ECA check to really re-run. Merged now. Thanks @HannesWell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove the unnecessary specification of the property
org.eclipse.equinox.p2.type.product=true, which Tycho/P2 already set by default.Similar to eclipse-platform/eclipse.platform.releng.aggregator#1459.