Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details about logging support #59

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Add details about logging support #59

merged 2 commits into from
Sep 7, 2023

Conversation

jonahgraham
Copy link
Contributor

Part of #27

@jonahgraham
Copy link
Contributor Author

@HannesWell can you have a look at this and see if it meets your expectations?

@jonahgraham
Copy link
Contributor Author

Rendered version is here: https://github.com/eclipse-packaging/packages/blob/changelog-entry-for-logging/CHANGELOG.md

HannesWell
HannesWell approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks you.

Just one typo.

CHANGELOG.md Outdated Show resolved Hide resolved
@jonahgraham @HannesWell
Update CHANGELOG.md
1f2b7e2 
Co-authored-by: Hannes Wellmann <[email protected]>
@jonahgraham jonahgraham merged commit b25cbdb into master Sep 7, 2023
22 checks passed
@jonahgraham jonahgraham deleted the changelog-entry-for-logging branch September 7, 2023 21:22
@jonahgraham
Copy link
Contributor Author

Thanks @HannesWell for the review - this will appear on https://eclipseide.org/release/noteworthy/ when release is made next week.

@HannesWell
Copy link
Contributor

Thanks @HannesWell for the review - this will appear on https://eclipseide.org/release/noteworthy/ when release is made next week.

That's nice. Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HannesWell HannesWell HannesWell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahgraham @HannesWell